Repository navigation
chore(app): move tailwindcss to devDependencies - #59018
Conversation
There was a problem hiding this comment.
Looks good. bun install --frozen-lockfile accepts the lockfile, Tailwind is still installed for the app, vite build in packages/app succeeds, and tsc -b passes. The typecheck script itself can't run here because bun check isn't available in this environment. Nothing in the app loads tailwindcss at runtime, and the repo's only --production install (packages/stats/server/Dockerfile) doesn't cover the app.
Public API: unchanged.
There was a problem hiding this comment.
The new commits are a rebase onto a newer dev. The PR's own diff is still just the tailwindcss move. I re-checked it on the new head: bun install --frozen-lockfile reports no changes, vite build in packages/app succeeds, and tsc -b passes. No new concerns.
Public API: unchanged.
What it does
Moves
tailwindcssfromdependenciestodevDependenciesinpackages/app. Nothing in the app imports it at runtime. Only the@tailwindcss/viteplugin (already a dev dependency) and the CSS@importuse it, both at build time.How it works
One manifest line moves, and
bun.lockrecords it. Versions are unchanged.I left
lighthouseinpackages/desktop/package.jsonon purpose. Nothing indesktopimports it, butgui-extensionsloads it withawait import("lighthouse")from the bundled main process. electron-vite keeps everything independenciesexternal and ships it, so removing it there would make the browser Lighthouse audit fail in packaged builds, or pull Lighthouse into the main bundle.Risk
Install layout only. Anything that installs with
--productionwould no longer fetchtailwindcssfor the app, which is correct since the app is only built, not run from its own manifest.Proof
bun typecheckinpackages/app: clean.bun install: lockfile updated by one line.