Skip to content

chore(app): move tailwindcss to devDependencies - #59018

Merged
kitlangton merged 1 commit into
devfrom
trim-deps
Oct 25, 2026
Merged

kitlangton merged 1 commit into
devfrom
trim-deps

Conversation

@kitlangton

Copy link
Copy Markdown
Contributor

What it does

Moves tailwindcss from dependencies to devDependencies in packages/app. Nothing in the app imports it at runtime. Only the @tailwindcss/vite plugin (already a dev dependency) and the CSS @import use it, both at build time.

How it works

One manifest line moves, and bun.lock records it. Versions are unchanged.

I left lighthouse in packages/desktop/package.json on purpose. Nothing in desktop imports it, but gui-extensions loads it with await import("lighthouse") from the bundled main process. electron-vite keeps everything in dependencies external and ships it, so removing it there would make the browser Lighthouse audit fail in packaged builds, or pull Lighthouse into the main bundle.

Risk

Install layout only. Anything that installs with --production would no longer fetch tailwindcss for the app, which is correct since the app is only built, not run from its own manifest.

Proof

  • bun typecheck in packages/app: clean.
  • bun install: lockfile updated by one line.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. bun install --frozen-lockfile accepts the lockfile, Tailwind is still installed for the app, vite build in packages/app succeeds, and tsc -b passes. The typecheck script itself can't run here because bun check isn't available in this environment. Nothing in the app loads tailwindcss at runtime, and the repo's only --production install (packages/stats/server/Dockerfile) doesn't cover the app.

Public API: unchanged.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new commits are a rebase onto a newer dev. The PR's own diff is still just the tailwindcss move. I re-checked it on the new head: bun install --frozen-lockfile reports no changes, vite build in packages/app succeeds, and tsc -b passes. No new concerns.

Public API: unchanged.

@kitlangton
kitlangton merged commit 28907e8 into dev Oct 25, 2026
20 checks passed
@kitlangton
kitlangton deleted the trim-deps branch October 25, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant