Repository navigation
chore(app): drop @dnd-kit/helpers - #59015
Merged
Merged
Conversation
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks good. The local arrayMove matches @dnd-kit/helpers@0.5.0 line for line, and nothing else in the repo imports the package. I compared it with the package source; the new tests pass and tsc --noEmit for packages/app is clean.
Public API is unchanged: this is an internal app helper and a dependency removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Removes
@dnd-kit/helpersfrom the app. It was imported for one function,arrayMove, in the queue panel and the tab strip.How it works
runtime/array-move.tsholds a localarrayMovewith the same behavior as the package: it returns the same array whenfrom === to, and otherwise copies the array and moves the item. Both call sites import it. Nothing else in the repo imports the package, so it is removed frompackages/app/package.jsonandbun.lock(three lines).Risk
Reordering queued prompts and tabs by drag. The function is the package's own logic, covered by new tests.
Proof
bun test ./src/runtime/array-move.test.tsinpackages/app: 3 pass (forward, backward, no mutation, same array when nothing moves).bun typecheckinpackages/app: clean.bun script/lint-changed.ts origin/dev: 0 problems.