Repository navigation
fix(core): hide Codex models ChatGPT accounts reject - #58180
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Looks good. I ran the updated provider-openai.test.ts against the base code, and it fails there because gpt-5.5 is enabled under ChatGPT sign-in. With this change it passes (5/5), and typecheck in packages/core is clean. I couldn't check the actual Codex rejection without a real ChatGPT account.
The new minor > 5 cutoff hides gpt-5.5, gpt-5.5-fast, gpt-5.5-pro and gpt-5.3-codex-spark. gpt-5.6-* and gpt-6* models stay enabled, and the 400k/272k and gpt-6.1-sol caps are unchanged.
Public API: unchanged. Only which models the OpenAI plugin enables under ChatGPT sign-in changes.
No concerns.
Related: #47646
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
None
Type of change
What does this PR do?
Problem: With the ChatGPT browser or headless sign-in (Codex backend), we explicitly allowed
gpt-5.5andgpt-5.3-codex-spark. The Codex backend rejects both for ChatGPT accounts ("not supported when using Codex with a ChatGPT account"), so the model picker offered models that always fail. Spark also got the blanket 400k/272k Codex cap, which is larger than its real 128k/100k window.Change: Remove the allowlist and raise the version cutoff from "newer than 5.4" to "newer than 5.5". That also covers
gpt-5.5-pro, so it no longer needs an entry in the blocklist.Out of scope:
chatgpt.ts) still listsgpt-5.5andgpt-5.5-fastas fallbacks. It uses the API endpoint rather than Codex, and we haven't seen it reject them.How did you verify your code works?
bun test test/plugin/provider-openai.test.tsinpackages/core: 5 pass. The ChatGPT filtering test now checks that gpt-5.5 and Spark are hidden, and checks cost, headers, and caps on gpt-5.6-sol.bun typecheckinpackages/core: clean.Screenshots / recordings
N/A
Checklist
Added by the opencode bot (AI-generated).
Related: #47646