Repository navigation
fix(core): map legacy apply_patch permissions to edit - #57900
Merged
Merged
Conversation
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks good. I passed {"permission":{"apply_patch":"deny"}} and {"tools":{"apply_patch":false}} through ConfigNormalize.normalize on the base and on this branch. On the base both became a rule for an apply_patch action that nothing checks. With this change both become an edit deny, which the patch tool does check. The updated test fails on the base and passes here; test/config (249 pass) and typecheck in packages/core are clean.
Public API: no config keys are added or removed. Legacy apply_patch entries under permission / tools now apply to the edit permission, which matches the docs. Backwards compatible.
No concerns.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #50183
Type of change
What does this PR do?
Problem. V1 treated
apply_patchas part of theeditpermission family, and the docs still list it there. The V1 config migration mapswriteandpatchtoeditbut notapply_patch. So{ "permission": { "apply_patch": "deny" } }(ortools: { apply_patch: false }) became a rule for anapply_patchaction that no tool checks, and the deny silently did nothing.Change. Map
apply_patchtoeditalongsidewriteandpatch:Both the
permissionandtoolsmigration paths go throughnormalizeAction, so both are covered.How did you verify your code works?
From
packages/core:Screenshots / recordings
No UI changes.
Checklist