Repository navigation
fix(tui): show keyboard focus in export options - #57154
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Looks good. I ran /export in the TUI with opencode-drive on the base and on this branch. On the base, focus on Copy is invisible. Here Copy gets the focused fill, and shift+tab moves focus back to "Include tools". The new test passes and packages/tui type-checks.
Using action.primary.focused for the focused row matches how DialogSelect and DialogConfirm already show focus, and the test is small and frame-driven.
The public API is unchanged: this only changes TUI dialog styling and adds a dialog-local keybind.
Related: #36302
jlongster
force-pushed
the
export-options-focus
branch
from
October 19, 2026 18:48
09565f2 to
4588b31
Compare
This was referenced Oct 20, 2026
23 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


In Export options (
/export), keyboard focus was invisible in places:Fields now use the same styling as the question form (
routes/session/form.tsx):text.formfield.focusedon the focused row, otherwisetext.formfield.base, whether or not it's checked.◉/○,[x]/[ ]):formfield.focusedwhen focused,formfield.selectedwhen checked, otherwisemuted. Only the mark shows what's checked.Other changes
action.primary.focused/.base). Before, it always used a borrowedraised.highbackground.Tests: new
test/component/dialog-export-options.test.tsxchecks that only the focused label is highlighted (checked ones stay base), that tab ×4 reaches Copy with the focused background, and that shift+tab moves back.test/componentandtest/uipass.Screenshots
Before and after, from the opencode-drive screenshot harness (120×36).
New designs off (opencode theme)
New designs on (
new-designsexperiment, opencode2 theme)Here
copyandsave to fileare footer actions with their own keys (c/enter), not tab stops, so tab cycles the options and checkboxes only.