Repository navigation
fix(merman): treat apostrophes in flowchart labels as text - #57060
Merged
Merged
Conversation
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Looks good. On the base branch, flowchart statements with an apostrophe in an unquoted node label or edge label (e.g. CS[Console's own schema copy] -. validates .-> CFG, A -- it's ok --> B) fail with "Unsupported syntax". With this change they parse correctly. Apostrophes in double-quoted labels and |...| edge labels behave the same as before, and single-quoted labels are still unwrapped. bun test (506 pass) and bun run typecheck pass in packages/merman.
Public API: unchanged (internal parser only).
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A flowchart label with an apostrophe, like
CS[Console's own schema copy] -. validates .-> CFG, made the whole diagram fail with "Unsupported syntax".The flowchart statement scanners counted
'as a string delimiter. An apostrophe inside an unquoted label opened a string that never closed, so the edge operator after it was masked and never found. Mermaid flowchart strings use double quotes only, so the scanners (splitNodeGroup,maskNodeLabelOperators,hasInternalStatementSeparator) now track only".Bracketed labels still mask operators,
;and&as before. Single-quoted labels are still unwrapped bystripMermaidQuotes.Tests:
bun testinpackages/merman(506 pass, layout audit 0 violations) andbun run typecheck. The new test fails ondevwithout the parser change.Requested by: @vimtor (victor via Slack)