Repository navigation
fix(tui): report x64 emulation on Windows ARM64 - #54984
Merged
Merged
Conversation
Under Prism, process.arch is x64, so crash reports, the debug dialog and the report skill made ARM64 failures look like x64 ones. PROCESSOR_IDENTIFIER still names the ARM host.
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The change looks sound. I couldn't run it on Windows ARM64, so I checked describeArch() by faking the platform, arch and PROCESSOR_IDENTIFIER. An emulated x64 build reports x64, emulated on ARM64. Native arm64, x64 on Intel, a missing PROCESSOR_IDENTIFIER, and non-Windows platforms all return process.arch as before. Type checks pass for util, tui and core, and the core report skill test passes.
Public API is unchanged: the change adds an internal @opencode/util/arch module and only changes diagnostic text.
No concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostics on Windows ARM64 could not tell a native build from an x64 build running under Prism emulation. Under emulation,
process.archandPROCESSOR_ARCHITECTUREboth report x64. Emulated x64 builds are the most common crash cause in Windows ARM64 reports (#4340, #5556, #10302, #40482, #41099), and those reports read as plain x64.PROCESSOR_IDENTIFIERis not rewritten for emulated processes, so it still names the host CPU (ARMv8 (64-bit) Family 8 …).describeOS)Windows 10.0.26200 (x64)Windows 10.0.26200 (x64, emulated on ARM64)Windows_NT 10.0.26200 (win32 x64)Windows_NT 10.0.26200 (win32 x64, emulated on ARM64)Native ARM64 and x64 machines are unchanged. The desktop app's sidecar runs under the same emulation as the app, so its report skill now shows emulation too.