Repository navigation
fix(cli): prioritize path-matched package manager and extend probe timeout - #54622
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
The change looks sound. I confirmed the new ordering test fails against the base updater.ts and passes with this change. The updater tests and the packages/cli type check pass. I didn't check the timeout part on Windows, but the probes run concurrently, so 30s is the longest the detection can now take.
Public API: unchanged.
One edge case is noted inline: a pnpm install path also contains npm, so npm still wins there.
Fixes #51604
rekram1-node
force-pushed
the
sort-pkg-checks
branch
3 times, most recently
from
October 11, 2026 21:15
140e705 to
6a7879f
Compare
rekram1-node
force-pushed
the
sort-pkg-checks
branch
from
October 11, 2026 21:19
6a7879f to
465c1e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
executablecontains the package manager name (matching V1 behavior) so the owning package manager is preferred when multiple global installs exist.10 secondsto30 secondsso cold-startnpm list -gon Windows does not time out (cli: update skipped - installation method not found on Windows npm install #51604).Added by the opencode bot (AI-generated).
Fixes #51604