Skip to content

fix(cli): prioritize path-matched package manager and extend probe timeout - #54622

Merged
rekram1-node merged 2 commits into
devfrom
sort-pkg-checks
Oct 11, 2026
Merged

rekram1-node merged 2 commits into
devfrom
sort-pkg-checks

Conversation

@rekram1-node

@rekram1-node rekram1-node commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary


Added by the opencode bot (AI-generated).

Fixes #51604

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks sound. I confirmed the new ordering test fails against the base updater.ts and passes with this change. The updater tests and the packages/cli type check pass. I didn't check the timeout part on Windows, but the probes run concurrently, so 30s is the longest the detection can now take.

Public API: unchanged.

One edge case is noted inline: a pnpm install path also contains npm, so npm still wins there.

Fixes #51604

Comment thread packages/cli/src/services/updater.ts Outdated
@rekram1-node
rekram1-node force-pushed the sort-pkg-checks branch 3 times, most recently from 140e705 to 6a7879f Compare October 11, 2026 21:15
@rekram1-node
rekram1-node merged commit 707de58 into dev Oct 11, 2026
9 checks passed
@rekram1-node
rekram1-node deleted the sort-pkg-checks branch October 11, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cli: update skipped - installation method not found on Windows npm install

1 participant