Repository navigation
fix(app): clear todo dock after fade-out instead of just hiding it - #52813
Chunai-Bboy wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
needs:compliance
|
The following comment was made by an LLM, it may be inaccurate: |
github-actions
Bot
removed
the
needs:compliance
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
The todo dock only hides when the last item finishes - it never clears. Old items therefore reappear on the next session open, and the sync used to force a re-fetch that pulled them straight back from the database. - call clear() after the fade-out completes in session-composer-state - drop the force/cached arguments so a closed dock stays closed The fetch itself is unchanged: an open dock still loads from the database. Refs anomalyco#41359
ef95bbd to
02bd2e6
Compare
|
Rebased onto the current The diff is unchanged — the 14 commits in between never touched Heads-up on the CI jobs: they are stuck at "waiting for status report" because workflows from a fork need maintainer approval to run. Local |
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
|
Before porting I read through the V2 composer. So this fix is probably moot against V2 as well, and I will not open a V2 PR unless one of you confirms the stale-resurrection behavior still exists. Two things worth keeping in mind if it does: the server-side rows are still never deleted ( |
Issue for this PR
Closes #41359
Type of change
What does this PR do?
The todo dock only hides when the last item finishes - it never clears. So the old items come back on the next session open, and the sync used to force a re-fetch that pulled them straight back from the database.
Two small things in the app cause it:
session-composer-state.ts- thesetTimeoutinscheduleClosesetsdock: falseand stops the timer, but never calls theclear()that sits right above it.pages/session.tsx- the todo sync passesforce: trueand a cached fallback, so it re-fetches stale rows even after the dock closed.This calls
clear()after the fade-out completes, and drops theforce/cached args so a closed dock stays closed.The fetch itself is untouched - if the dock is open it still loads from the database.
Known limit: this is client-side only. The server-side rows are not deleted.
session.todois registered as GET only andTodo.Interfaceexposes justupdateandget, so there is currently no endpoint a client could call to clear them. Consumers readingGET /session/{id}/tododirectly - third-party UIs, plugins - will still see the stored list. Clearing server-side needs an API that does not exist yet; that would be a separate change, and the "when to clear" semantics are a maintainer decision.How did you verify your code works?
I traced the state machine in
todoStateand confirmed the existingsession-composer-stateunit tests still describe the same transitions. Localtsc --noEmitover both changed files reports nothing beyond missing-dependency noise (Cannot find module), identical to an unmodified checkout ofdev. I have not run the full suite or the app build.Screenshots / recordings
None.
Checklist