Repository navigation
fix(mcp): pass tool input as permission metadata - #51062
Merged
rekram1-node merged 3 commits intoOct 14, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
3 tasks done
This was referenced Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #51061
Type of change
What does this PR do?
The MCP tool wrapper asserted permission with
metadata: {}, sopermission.evaluatehooks andpermission.askedconsumers could not see what an MCP call was about to do. It now passes the tool input undermetadata.input, so other permission metadata can be added later without mixing with the tool's own arguments.action,resourcesandsaveare unchanged, so rule matching and saved approvals behave as before.v2 port of #48464.
How did you verify your code works?
waits for permission before calling an MCP tooltest inpackages/core/test/mcp.test.tsto call the tool with an argument and assert it arrives asmetadata.input. It fails without the fix and passes with it.bun test test/mcp.test.tsandbun typecheckinpackages/core.Screenshots / recordings
No UI change.
Checklist