fix(provider): strip properties/required from non-object types in Gemini schema#11888
Merged
rekram1-node merged 2 commits intoanomalyco:devfrom Feb 3, 2026
Conversation
…ini schema Gemini API rejects tool schemas where 'properties' or 'required' fields are present on non-object types. This commonly occurs with MCP tools (e.g., Notion MCP) that define these fields on array or other types. Error example: GenerateContentRequest.tools[0].function_declarations[80].parameters.properties[data].properties: only allowed for OBJECT type This fix extends sanitizeGemini to remove properties/required from any schema node where type is not 'object'. Fixes issues similar to anomalyco#3140, anomalyco#8036
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Collaborator
|
can u add tests for this too |
… schema Add test cases for sanitizeGemini to verify: - properties removed from non-object types (string, number, array) - required removed from non-object types - nested non-object types are handled recursively - object types retain properties and required - non-gemini providers are unaffected
ishaksebsib
pushed a commit
to ishaksebsib/opencode
that referenced
this pull request
Feb 4, 2026
ishaksebsib
pushed a commit
to ishaksebsib/opencode
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gemini API rejects tool schemas where
propertiesorrequiredfields are present on non-object types. This commonly occurs with MCP tools (e.g., Notion MCP) that define these fields incorrectly.Fixes #11889
Problem
When using MCP servers like Notion, the tool schemas may have
propertiesorrequiredon non-object types, causing:Solution
Extend
sanitizeGeminiintransform.tsto removepropertiesandrequiredfrom any schema node wheretypeis not"object".Changes
packages/opencode/src/provider/transform.ts: Added 6 lines to strip invalid propertiesRelated Issues