Make @annotorious/openseadragon a peerDependency of @annotorious/react#589
Open
blchelle wants to merge 1 commit intoannotorious:mainfrom
Open
Make @annotorious/openseadragon a peerDependency of @annotorious/react#589blchelle wants to merge 1 commit intoannotorious:mainfrom
blchelle wants to merge 1 commit intoannotorious:mainfrom
Conversation
blchelle
commented
Nov 10, 2025
| }, | ||
| "peerDependencies": { | ||
| "openseadragon": ">= ^4.0.0 || >= ^5.0.0", | ||
| "@annotorious/openseadragon": "3.7.14-beta", |
Author
There was a problem hiding this comment.
I am not certain what versions of @annotorious/openseadragon we want to enforce for the peerDependency.
Author
|
Going to close this since it seems like it's not going to get any action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
@annotorious/openseadragonpackage is currenctly a hard dependency of the@annotorious/reactpackage, even if the consumer has no desire to use the specific components that leverage@annotorious/openseadragon. Being forced to install@annotorious/openseadragonhas a negative impact on bundle size, especially because that also requires the consumer to install theopenseadragonpackage.Changes
openseadragondependent code into a separate export@annotorious/react/openseadragonNote: I believe this will likely require a major version upgrade since we're changing the import path for all of the OpenSeaDragon related components.
Closes #588