-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathControl-Statement.js
More file actions
56 lines (45 loc) · 1.13 KB
/
Control-Statement.js
File metadata and controls
56 lines (45 loc) · 1.13 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
//: 17.1 => /* In case your statement (if, while etc) gets too long or exceeds the maximum line length, each (grouped) condition could be put into a new line. The logical operator should begin the line. */
/* Why? Requiring operators at the beginning of the line keeps the operators aligned and follows a pattern similar to method chaining. This also improves readability by making it easier to visually follow complex logic. */
// bad
if (
(foo === 123 || bar === "abc") &&
doesItLookGoodWhenItBecomesThatLong() &&
isThisReallyHappening()
) {
thing1();
}
// bad
if (foo === 123 && bar === "abc") {
thing1();
}
// bad
if (foo === 123 && bar === "abc") {
thing1();
}
// bad
if (foo === 123 && bar === "abc") {
thing1();
}
// good
if (foo === 123 && bar === "abc") {
thing1();
}
// good
if (
(foo === 123 || bar === "abc") &&
doesItLookGoodWhenItBecomesThatLong() &&
isThisReallyHappening()
) {
thing1();
}
// good
if (foo === 123 && bar === "abc") {
thing1();
}
//: 17.2 => Don't use selection operators in place of control statements.
// bad
!isRunning && startRunning();
// good
if (!isRunning) {
startRunning();
}