Skip to content

refactor: rename ScheduleReminders, use viewbinding in AddEditReminderDialog#21060

Draft
ericli3690 wants to merge 2 commits into
ankidroid:mainfrom
ericli3690:ericli3690-schedule-reminders-add-edit-vb
Draft

refactor: rename ScheduleReminders, use viewbinding in AddEditReminderDialog#21060
ericli3690 wants to merge 2 commits into
ankidroid:mainfrom
ericli3690:ericli3690-schedule-reminders-add-edit-vb

Conversation

@ericli3690
Copy link
Copy Markdown
Member

Purpose / Description

Renames ScheduleReminders to ScheduleRemindersFragment. Refactors AddEditReminderDialog to use viewbinding.

Fixes

  • Precursor to the larger fragment refactor and UI cleanup I'm working on for the review reminders system: making sure the UI looks good on mobile, tablet, edge-to-edge, no matter where it's opened from, adhering to the styling of the Settings pages, etc. etc... it's taking a while long than I would like, so let's get this bit I'm 100% confident in merged first.

How Has This Been Tested?

  • Physical Lenovo M11 Tablet, API 35
  • Physical Samsung S23, API 34
  • Launching, opening screen from all sources, CRUD'ing reminders all works

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code

@ericli3690 ericli3690 self-assigned this May 16, 2026
Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 16, 2026
@ericli3690 ericli3690 marked this pull request as draft May 17, 2026 16:10
@ericli3690 ericli3690 removed the Needs Second Approval Has one approval, one more approval to merge label May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants