Codecov Report

Merging #736 into master will decrease coverage by 0.01%.
The diff coverage is 57.06%.

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   58.58%   58.57%   -0.02%     
==========================================
  Files         171      172       +1     
  Lines       38448    38837     +389     
==========================================
+ Hits        22525    22747     +222     
- Misses      15923    16090     +167

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f13303...764091d. Read the comment docs.

I'm confused: this is auto generated code, so is there somthing what I have todo for finishing this pull request?

Hi, no sorry, this is only a consequence of our code generator producing less code coverage than the existing code base :-) Not your fault so you can disregard this. Will review soon.

It looks good to me, a few comments

• Does it make sense to add any arithmetic or conversion methods while at it? See https://github.com/angularsen/UnitsNet/blob/master/UnitsNet/CustomCode/Quantities/Power.extra.cs as an example.

It looks good to me, a few comments

• Does it make sense to add any arithmetic or conversion methods while at it?

I think about - but its only in combination with a lot of other new Units nessesary [in normal this Unit is used to describe the PV module, not for calculating].

So: NonimalPower/Area or Currency/NominalPower is used ... But as we dont have Currency and NominalPower/Area is used very rarely I think for now its OK

Ok, I'm fine with adding it then.

I tried to fix the merge conflict for you, because it is my fault having changed the folder structure in the code generator output recently, but I can't push commits to your master branch to fix it.

Two options:

1. Create a new branch add-nominal-power based on latest angularsen/master (not your fork's master), copy the JSON file and NominalPowerTests.cs to it, regenerate the code and create a new pull request from this branch.
2. Or I can merge it for you locally, but your name would not be on the PR.

Let me know how you would like to proceed or if you need any assistance on option 1.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.