check to make sure node being removed is intended node#1014
Open
bryanstrader wants to merge 2 commits intoangular-ui-tree:masterfrom
bryanstrader:master
Open
check to make sure node being removed is intended node#1014bryanstrader wants to merge 2 commits intoangular-ui-tree:masterfrom bryanstrader:master
bryanstrader wants to merge 2 commits intoangular-ui-tree:masterfrom
bryanstrader:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the nodesCtrl.js the removeNode function doesn't check the index before splicing the array, this was creating issues in my application because I remove node on drop event in one controller and then this removeNode would fire and end up removing an unintended node because by the time it calls splice the index represents a different node.