Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular-package/callback
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: angular-package/callback
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.0.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 12 files changed
  • 1 contributor

Commits on Sep 12, 2021

  1. refactor(ResultHandler): add the value parameter of a generic type … 

    …variable `Value`.
    @sciborrudnicki
    sciborrudnicki committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    baace82 View commit details
    Browse the repository at this point in the history

  2. refactor(ResultCallback): add the value parameter of a generic type… 

    … variable `Value`. Remove `extends object` from the `Payload`. Update jsdoc.
    @sciborrudnicki
    sciborrudnicki committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    744f225 View commit details
    Browse the repository at this point in the history

  3. refactor(CallbackPayload): change to the type instead of `interface… 

    …` with a generic type variable `Payload` equal to `object`.
    @sciborrudnicki
    sciborrudnicki committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    ac3c8af View commit details
    Browse the repository at this point in the history

  4. feat(ForEachCallback): add type for the .forEach() method.

    @sciborrudnicki
    sciborrudnicki committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    65e6880 View commit details
    Browse the repository at this point in the history

  5. chore(type): add exports CallbackPayload, ForEachCallback.

    @sciborrudnicki
    sciborrudnicki committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    4015750 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2021

  1. docs(README.md): update.

    @sciborrudnicki
    sciborrudnicki committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    254ee34 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. docs(README.md): update.

    @sciborrudnicki
    sciborrudnicki committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    3bc8a46 View commit details
    Browse the repository at this point in the history

  2. docs(README.md): update.

    @sciborrudnicki
    sciborrudnicki committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    9364ca0 View commit details
    Browse the repository at this point in the history

  3. chore(package): update.

    @sciborrudnicki
    sciborrudnicki committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    f974e0f View commit details
    Browse the repository at this point in the history

  4. refactor: remove unnecessary files.

    @sciborrudnicki
    sciborrudnicki committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    888ca77 View commit details
    Browse the repository at this point in the history

  5. refactor(ResultHandler): extend generic type variable Payload by th… 

    …e object.
    @sciborrudnicki
    sciborrudnicki committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    a62a967 View commit details
    Browse the repository at this point in the history

  6. refactor(Callback): general update and jsdoc. 

    Add:
- static method `defineForEachCallback()`,
- public instance method `setForEachCallback()`, `getForEachCallback()`,

Change:
- public instance method `getCallback()` name to `getResultCallback()`.
- parameter `capturePayload?: Payload` to `defaultPayload?: Payload` in the method `setResultCallback()`, `defineResultCallback()`, `defineErrorCallback()` as the default value of `payload` parameter,
- use direct functions instead of object `is` and `guard`,
- `ResultHandler` type to use generic type variable `Value`,
- `defineErrorCallback()`, `setErrorCallback()` method by adding `resultHandler` parameter of `ResultHandler` type to handle parameters before the thrown error,
    @sciborrudnicki
    sciborrudnicki committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    bbeede1 View commit details
    Browse the repository at this point in the history

  7. chore(api): remove unnecessary.

    @sciborrudnicki
    sciborrudnicki committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    96214e8 View commit details
    Browse the repository at this point in the history

  8. test: update.

    @sciborrudnicki
    sciborrudnicki committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    63e68d1 View commit details
    Browse the repository at this point in the history

  9. docs(README.md): update.

    @sciborrudnicki
    sciborrudnicki committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    ebb706e View commit details
    Browse the repository at this point in the history

  10. docs(README.md): update.

    @sciborrudnicki
    sciborrudnicki committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    d880f00 View commit details
    Browse the repository at this point in the history

  11. docs(README.md): update.

    @sciborrudnicki
    sciborrudnicki committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    9be7c3f View commit details
    Browse the repository at this point in the history
Loading