Repository navigation
Conversation
|
I've fixed several of the tests but I'm too unfamiliar with this area to go about fixing the rest of the tests. |
|
ChromeDriver and GeckoDriver actually download the latest. The config.json is out of date and parts of them should be removed / cleaned up. |
|
I am also unfamiliar with e2e_spec/*.ts files. Are these fixes to existing tests that fail? |
|
Here is the previous test run with the failures. https://circleci.com/gh/angular/webdriver-manager/165 A couple were formatting. The others as far as I can tell were checking the API response from Selenium which appears to be returning a different success object than it use to. I'm don't know much about it but based on this doc and the tests were wrong. https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#responses |
| resp.on('data', (chunk) => logs += chunk); | ||
| resp.on('end', () => { | ||
| expect(logs).toContain('"state":"success"'); | ||
| expect(logs).toContain('"status":0'); |
There was a problem hiding this comment.
Could you explain this? Or list the log message in a comment.
| "selenium": "2.53.1", | ||
| "chromedriver": "2.27", | ||
| "geckodriver": "v0.13.0", | ||
| "chromedriver": "2.32", |
There was a problem hiding this comment.
Sure? I think these get initialized but I believe they are always replaced. This section should be removed soon.
|
This might require a rebase. Thanks! |
|
Since |
Updating chromedriver to get access to Shadow DOM v1 for testing angular/angular#19059.