Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

feat(aot): Universal 2.1.0-rc.1 - AoT support for Node/Browser - #577

Closed
PatrickJS wants to merge 30 commits into
masterfrom
update-angular-2-0-1
Closed

PatrickJS wants to merge 30 commits into
masterfrom
update-angular-2-0-1

Conversation

@PatrickJS

@PatrickJS PatrickJS commented Oct 5, 2016 •

Copy link
Copy Markdown
Contributor
npm install 
gulp pre-publish
cd to examples/express-aot
npm run ngc && npm run build

update:
I need to split this PR out so webpack, typescript, and angular updates will be done in another repo then rebased here. We're blocked on this PR until a PR is released in the angular repo or if we find a workaround

update:

  • update to 2.1.0

@PatrickJS PatrickJS changed the title Update angular 2.0.1 and webpack 2 WIP: Update angular 2.0.1 and webpack 2 Oct 5, 2016
Comment thread modules/platform-node/node-http.ts Outdated

@Injectable()
export class NodeConnection implements XHRConnection {
export class NodeConnection /*implements XHRConnection*/ {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ngc needs this

Comment thread modules/platform-node/node-http.ts Outdated
_browserXHR: BrowserXhr,
_xsrfStrategy: XSRFStrategy,
// _browserXHR: BrowserXhr,
// _xsrfStrategy: XSRFStrategy,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ngc needs these

@PatrickJS

Copy link
Copy Markdown
Contributor Author

ok I pushed up latest and I'm blocked by typescript and AoT someone can reproduce

npm install 
gulp pre-publish
cd to examples/express-aot
npm run ngc && npm run build

@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@PatrickJS PatrickJS self-assigned this Oct 10, 2016
@PatrickJS

Copy link
Copy Markdown
Contributor Author

I need to split this PR out so webpack, typescript, and angular updates will be done in another repo then rebased here. We're blocked on this PR until a PR is released in the angular repo or if we find a workaround

@PatrickJS PatrickJS changed the title WIP: Update angular 2.0.1 and webpack 2 AoT support for Node/Browser Oct 10, 2016
@steve8708

Copy link
Copy Markdown
Contributor

Just pushed an update to my angular pr that I've verified also resolves the runtime issues as well, so with that change the AOT example now builds and runs end to end for me 👍

@steve8708

Copy link
Copy Markdown
Contributor

The PR has been reviewed and marked LGTM so should be merge anytime now

@steve8708

Copy link
Copy Markdown
Contributor

blocker PR in angular is now merged 🎉

@steve8708

Copy link
Copy Markdown
Contributor

just hooked a build of this branch up with the latest angular build to a fairly large project and the universal + aot integration works end to end like a charm 👍

and my god it is FAST!!! 🎉 🎉 🎉

@steve8708

steve8708 commented Oct 12, 2016 •

Copy link
Copy Markdown
Contributor

I'm running prelimary load testing on the site I integrated universal + aot (compared to another branch on universal + jit) and I'm measuring anywhere from 4-10x faster render times on the server, able to handle 2-10x more concurrency, and is 4-5x more memory efficient

these are just quick and dirty tests but the results are extremely promising thus far!!! 🍾 🍾 🍾

@steve8708

Copy link
Copy Markdown
Contributor

We will release something to production soon and I'll report back on the measured results in the wild

@MarkPieszak

MarkPieszak commented Oct 12, 2016 •

Copy link
Copy Markdown
Contributor

Wow really that big of gains? 😀😍😎
Now we're talking!

@PatrickJS
PatrickJS force-pushed the update-angular-2-0-1 branch from 3d7c56d to bf3dbc5 Compare October 13, 2016 00:24
@PatrickJS
PatrickJS force-pushed the update-angular-2-0-1 branch 2 times, most recently from 10b967c to 74c2d7a Compare October 13, 2016 00:28
@PatrickJS
PatrickJS force-pushed the update-angular-2-0-1 branch from fe8b207 to 4df96c5 Compare October 13, 2016 00:55
@PatrickJS PatrickJS changed the title AoT support for Node/Browser universal 2.1.0 - AoT support for Node/Browser Oct 13, 2016
@PatrickJS PatrickJS changed the title universal 2.1.0 - AoT support for Node/Browser Universal 2.1.0 - AoT support for Node/Browser Oct 13, 2016
@PatrickJS
PatrickJS force-pushed the update-angular-2-0-1 branch from b55a7e4 to 2446eb4 Compare October 13, 2016 01:31
@PatrickJS
PatrickJS force-pushed the update-angular-2-0-1 branch from 2446eb4 to a5d7623 Compare October 13, 2016 01:36
@PatrickJS PatrickJS changed the title Universal 2.1.0 - AoT support for Node/Browser Universal 2.1.0-rc.1 - AoT support for Node/Browser Oct 13, 2016
@MarkPieszak MarkPieszak changed the title Universal 2.1.0-rc.1 - AoT support for Node/Browser feat(aot): Universal 2.1.0-rc.1 - AoT support for Node/Browser Oct 18, 2016
@elekzalan

Copy link
Copy Markdown

Hello. Any news here? I'm really excited to see those perf improvements. Keep up the good work!

@steve8708

Copy link
Copy Markdown
Contributor

@elekzalan this has already been published with @angular/universal@2.1.0-rc.1

@PatrickJS PatrickJS closed this Jan 8, 2017
@CaerusKaru
CaerusKaru deleted the update-angular-2-0-1 branch February 25, 2018 21:24
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants