Repository navigation
Conversation
|
|
||
| @Injectable() | ||
| export class NodeConnection implements XHRConnection { | ||
| export class NodeConnection /*implements XHRConnection*/ { |
| _browserXHR: BrowserXhr, | ||
| _xsrfStrategy: XSRFStrategy, | ||
| // _browserXHR: BrowserXhr, | ||
| // _xsrfStrategy: XSRFStrategy, |
|
ok I pushed up latest and I'm blocked by typescript and AoT someone can reproduce |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
I need to split this PR out so webpack, typescript, and angular updates will be done in another repo then rebased here. We're blocked on this PR until a PR is released in the angular repo or if we find a workaround |
|
Just pushed an update to my angular pr that I've verified also resolves the runtime issues as well, so with that change the AOT example now builds and runs end to end for me 👍 |
|
The PR has been reviewed and marked LGTM so should be merge anytime now |
|
blocker PR in angular is now merged 🎉 |
|
just hooked a build of this branch up with the latest angular build to a fairly large project and the universal + aot integration works end to end like a charm 👍 and my god it is FAST!!! 🎉 🎉 🎉 |
|
I'm running prelimary load testing on the site I integrated universal + aot (compared to another branch on universal + jit) and I'm measuring anywhere from 4-10x faster render times on the server, able to handle 2-10x more concurrency, and is 4-5x more memory efficient these are just quick and dirty tests but the results are extremely promising thus far!!! 🍾 🍾 🍾 |
|
We will release something to production soon and I'll report back on the measured results in the wild |
|
Wow really that big of gains? 😀😍😎 |
3d7c56d to
bf3dbc5
Compare
10b967c to
74c2d7a
Compare
fe8b207 to
4df96c5
Compare
b55a7e4 to
2446eb4
Compare
2446eb4 to
a5d7623
Compare
|
Hello. Any news here? I'm really excited to see those perf improvements. Keep up the good work! |
|
@elekzalan this has already been published with @angular/universal@2.1.0-rc.1 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
update:
I need to split this PR out so webpack, typescript, and angular updates will be done in another repo then rebased here. We're blocked on this PR until a PR is released in the angular repo or if we find a workaround
update: