Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

bug(platform-node): Throw error to parent catch of serializeModule - #551

Merged
PatrickJS merged 14 commits into
angular:update-angular-2-0-1from
MarkPieszak:master
Oct 13, 2016
Merged

PatrickJS merged 14 commits into
angular:update-angular-2-0-1from
MarkPieszak:master

Conversation

@MarkPieszak

Copy link
Copy Markdown
Contributor

Helps pass errors to .catch() of Zone.run( ... serializeModule() )
#550

@PatrickJS

Copy link
Copy Markdown
Contributor

did you test that this works?

@PatrickJS

Copy link
Copy Markdown
Contributor

I would think the error catching have to be in asyncPromiseSeries

@MarkPieszak

Copy link
Copy Markdown
Contributor Author

It seemed to work with random errors I tried throwing but should look into it more. In a wedding today so can't but could try it out more tomorrow!

Isn't there already a catcher in the async series that would bubble up?

@PatrickJS

Copy link
Copy Markdown
Contributor

@MarkPieszak any updates on this?

@MarkPieszak

Copy link
Copy Markdown
Contributor Author

@gdi2290 We should be all set (for now) with this at least from this end. It passes any errors thrown up to the caller.

@PatrickJS

Copy link
Copy Markdown
Contributor

LGTM

@PatrickJS

PatrickJS commented Oct 12, 2016 •

Copy link
Copy Markdown
Contributor

this is needed for asp.net and the PR can be squashed via github

@PatrickJS
PatrickJS changed the base branch from master to update-angular-2-0-1 October 13, 2016 01:10
@PatrickJS
PatrickJS merged commit ec4ab11 into angular:update-angular-2-0-1 Oct 13, 2016
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants