This repository was archived by the owner on Nov 22, 2024. It is now read-only.
fix(@nguniversal/builders): address method Promise.prototype.then called on incompatible receiver error#2879
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Oct 27, 2022
Conversation
alan-agius4
added
action: review
target: patch
3 tasks
alan-agius4
requested review from
devversion and
dgp1130
and removed request for
devversion
JiaLiPassion
suggested changes
Oct 26, 2022
alan-agius4
force-pushed
the
zone-js-patch-prerender
branch
from
1fd43f4 to
8e8fc81
Compare
JiaLiPassion
previously approved these changes
Oct 26, 2022
CaerusKaru
previously approved these changes
Oct 26, 2022
alan-agius4
dismissed stale reviews from CaerusKaru and JiaLiPassion
via
ac180a1
alan-agius4
force-pushed
the
zone-js-patch-prerender
branch
from
8e8fc81 to
ac180a1
Compare
…led on incompatible receiver error Prerendering does not work when using Node.js versions that contain the following commit nodejs/node#43728 due to `loadesm` is now using `SafePromiseAll` which is not handled properly by zone.js.
alan-agius4
force-pushed
the
zone-js-patch-prerender
branch
from
ac180a1 to
bc69d62
Compare
CaerusKaru
approved these changes
Oct 27, 2022
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerendering does not work when using Node.js versions that contain the following commit nodejs/node#43728 due to
loadesmis now usingSafePromiseAllwhich is not handled properly by zone.js.