This repository was archived by the owner on Dec 18, 2024. It is now read-only.
fix: replace use of turbo with yarn #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
reviewed
Jun 6, 2023
Turbo is being deprecated and can be replaced by yarn which is supported on StackBlitz.
Nemikolh
force-pushed
the
turbo-deprecated
branch
from
2f4e45d to
7a15448
Compare
Nemikolh
changed the title
devversion
reviewed
Jun 6, 2023
| .replace(/\${title}/g, data.description); | ||
| } else if (fileName === '.stackblitzrc') { | ||
| fileContent = fileContent.replace(/\${startCommand}/, isTest ? 'turbo test' : 'turbo start'); | ||
| fileContent = fileContent.replace(/\${startCommand}/, isTest ? 'yarn test' : 'yarn start'); |
Member
There was a problem hiding this comment.
I actually think we wanted npm right? The lock file is already a NPM lock file
Member
There was a problem hiding this comment.
I converted the Stackblitz template to yarn since npm was timing out. See #1194
Member
There was a problem hiding this comment.
Ah great! @d3lm what will be the Yarn support strategy with WebContainers? For angular.io we don't use Yarn, just turbo without a lock file apparently.
There was a problem hiding this comment.
@devversion How do you mean? For yarn we currently support yarn v1. Or maybe I am misunderstanding.
devversion
pushed a commit
that referenced
this pull request
Jun 6, 2023
Turbo is being deprecated and can be replaced by yarn which is supported on StackBlitz.
devversion
pushed a commit
that referenced
this pull request
Jun 6, 2023
Turbo is being deprecated and can be replaced by yarn which is supported on StackBlitz.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replace the use of
turbowithyarnasturbois being deprecated and StackBlitz has support foryarnv1 out of the box.See related PR: angular/angular#50576