This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Repository navigation
feat(@angular-devkit/schematics): support collection extension - #398
Merged
Merged
Conversation
Contributor
filipesilva
added
comp: angular-devkit/schematics
and removed
comp: angular-devkit/schematics
labels
hansl
suggested changes
Feb 1, 2018
hansl
left a comment
hansl
left a comment
Contributor
There was a problem hiding this comment.
2 little nits. Nothing major. Good work!
| "title": "Collection Schema for validating a 'collection.json'.", | ||
| "type": "object", | ||
| "properties": { | ||
| "extends": { |
Contributor
There was a problem hiding this comment.
How hard to add type: [ "array", "string" ] ?
| expect(schematic1.description.name).toBe('schematic1'); | ||
| }); | ||
|
|
||
| it('extends a collection ', () => { |
Contributor
There was a problem hiding this comment.
Should just add a test for listSchematicNames to avoid regression.
hansl
approved these changes
Feb 2, 2018
hansl
reviewed
Feb 2, 2018
|
|
||
| private _createCollectionDescription( | ||
| name: string, | ||
| parentNames?: Set<string>, |
Contributor
There was a problem hiding this comment.
Just one nit but not stopping the approval; parentNames = new Set<string>() then lower just add regardless of whether it's defined or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example usage (also supports an array of strings):
Closes #34