Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

fix(@angular-devkit/build-optimizer): wrap tsickle enums - #231

Merged
hansl merged 1 commit into
angular:masterfrom
filipesilva:tsickle-enums
Oct 23, 2017
Merged

hansl merged 1 commit into
angular:masterfrom
filipesilva:tsickle-enums

Conversation

@filipesilva

Copy link
Copy Markdown
Contributor

Fix #229

/cc @clydin

@filipesilva

Copy link
Copy Markdown
Contributor Author

@IgorMinar can you confirm that tsickle enums always have the /** @enum {word} */ comment? It is being used as the canary regex.

IgorMinar
IgorMinar previously approved these changes Oct 23, 2017
@IgorMinar

Copy link
Copy Markdown
Contributor

lgtm. I believe the regexp is correct.

@hansl
hansl merged commit 18190d9 into angular:master Oct 23, 2017
@filipesilva
filipesilva deleted the tsickle-enums branch October 23, 2017 16:20
gkalpak pushed a commit to IgorMinar/angular that referenced this pull request Nov 1, 2017
matsko pushed a commit to angular/angular that referenced this pull request Nov 1, 2017
matsko pushed a commit to angular/angular that referenced this pull request Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants