Fix MS Edge and Firefox issues #342, #388 - #393
Conversation
get latest
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
I've signed it 2 days ago, where is my cla:yes :)))) |
|
@davidgabrichidze This is caused by your multiple commits. Some commits are not committed properly with your GitHub Account Email. I suggest, squashing all commits into one, then the CLA check will pass properly. |
|
@devversion thanks for advise. So, I should close this PR and request another one, with joined commits? |
|
@davidgabrichidze That shouldn't be necessary. You can just squash the commits on this PR and force push the changes. Here is a useful Git Alias for Squashing And here is another link for squashing: http://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git |
Fix floating placeholder in Firefox, without affecting autofill behavior in Chrome/Safari Override and remove firefox box-shadow on required fields
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
@devversion Thanks, it worked 👍 |
| * Removes firefox box-shadow on required fields... | ||
| */ | ||
| :-moz-ui-invalid { | ||
| box-shadow: none; |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix md-input maxLength problem for MS Edge #388
Fix floating placeholder in Firefox, without affecting autofill behavior in Chrome/Safari #342