Skip to content

fix(multiple): change aria keyboard manager to only handle repeated events in correct places#32728

Open
adolgachev wants to merge 1 commit intoangular:mainfrom
adolgachev:aria-kb-repeat
Open

fix(multiple): change aria keyboard manager to only handle repeated events in correct places#32728
adolgachev wants to merge 1 commit intoangular:mainfrom
adolgachev:aria-kb-repeat

Conversation

@adolgachev
Copy link
Contributor

@adolgachev adolgachev commented Jan 29, 2026

The angular-aria keyboard manager ignores the event.repeat parameter so holding down a key will cause it to loop even when that behavior is not desired. In general, repeated events should only be handled when navigating with arrow keys, and especially not when toggling (as then it just goes from off to on to off and so on).

Another issue is that the browser can interpret a keyboard space or enter as a click in certain cases. This is true with the toolbar so added check for a proper mouse event to handle the click (else already handled with keyboard) as well as updated spec to pass a proper event.

Note: we are missing tests for this but they probably need to be added at a higher level so that we can catch for not just the repeat issue but also issues like the click above. Else can just add explicit repeat but keyDown events but that isn't as useful.

Fixes b/479281429.

@adolgachev adolgachev changed the title fix(aria/many): don't repeat keys fix(multiple): don't repeat keys Feb 3, 2026
@adolgachev adolgachev changed the title fix(multiple): don't repeat keys fix(aria/many): change aria keyboard manager to only handle repeated events in correct places Feb 4, 2026
@adolgachev adolgachev changed the title fix(aria/many): change aria keyboard manager to only handle repeated events in correct places fix(multiple): change aria keyboard manager to only handle repeated events in correct places Feb 4, 2026
@adolgachev adolgachev marked this pull request as ready for review February 4, 2026 22:54
@adolgachev adolgachev requested a review from ok7sai February 4, 2026 22:54
@pullapprove pullapprove bot requested a review from andrewseguin February 4, 2026 22:54
@adolgachev adolgachev requested review from tjshiu and removed request for andrewseguin February 4, 2026 22:55
@adolgachev adolgachev added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit labels Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessibility This issue is related to accessibility (a11y) action: presubmit The PR is in need of a google3 presubmit action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant