Skip to content

fix(material/badge): move warning check later#32724

Merged
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:27705/badge-warning
Jan 30, 2026
Merged

fix(material/badge): move warning check later#32724
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:27705/badge-warning

Conversation

@crisbeto
Copy link
Member

The badge has a check whether it's applied to an aria-hidden icon. This check happens very early which can cause false positives.

Fixes #27705.

The badge has a check whether it's applied to an `aria-hidden` icon. This check happens very early which can cause false positives.

Fixes angular#27705.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 29, 2026
@pullapprove pullapprove bot requested review from adolgachev and tjshiu January 29, 2026 09:41
@crisbeto crisbeto removed the request for review from adolgachev January 30, 2026 06:38
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 30, 2026
@crisbeto crisbeto merged commit a3f2ec8 into angular:main Jan 30, 2026
28 of 31 checks passed
@crisbeto
Copy link
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Jan 30, 2026
The badge has a check whether it's applied to an `aria-hidden` icon. This check happens very early which can cause false positives.

Fixes #27705.

(cherry picked from commit a3f2ec8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: material/badge target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Badge): Warning "badge on mat-icon with aria-hidden" doesn't check attr.aria-hidden

2 participants