fix(aria/combobox): fix selection via keyboard by passing proper item#32714
Open
adolgachev wants to merge 1 commit intoangular:mainfrom
Open
fix(aria/combobox): fix selection via keyboard by passing proper item#32714adolgachev wants to merge 1 commit intoangular:mainfrom
adolgachev wants to merge 1 commit intoangular:mainfrom
Conversation
adolgachev
added
Accessibility
|
Deployed dev-app for 103fe8e to: https://ng-dev-previews-comp--pr-angular-components-32714-dev-3240cirt.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
tjshiu
reviewed
Jan 30, 2026
Contributor
tjshiu
left a comment
tjshiu
left a comment
There was a problem hiding this comment.
Chatted about it - might need some more investigation time. Seems to work inconsistently.
adolgachev
force-pushed
the
aria-combobox-nav
branch
from
103fe8e to
2db54b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autocomplete example is broken when using keyboard navigation to select an item, as it appears selected, but then pressing clear does not have an effect. See b/479260216.
Fix is to properly pass in the active item within Combobox.select for when there is no item passed in the params. Note that the specs pass as there is another later for focused item and then another call to select passing in the item which results in the item appearing selected.
Need to spend more time determining how to modify specs to test for this, but this does appear to be a mistake in original code as the item is determined, then dropped in this code, and it fixes the issue.