feat(material/button): Add support for showing a progress indicator inside the button#32698
Open
jermowery wants to merge 2 commits intoangular:mainfrom
Open
feat(material/button): Add support for showing a progress indicator inside the button#32698jermowery wants to merge 2 commits intoangular:mainfrom
jermowery wants to merge 2 commits intoangular:mainfrom
Conversation
…nside the button Add a new API, testing API, and docs for allowing progress indicators to be projected into a button and have them shown in an accessible manner Fixes angular#13667
jermowery
force-pushed
the
progress-button
branch
from
bd4c6fb to
3352a2c
Compare
angular-robot
bot
added
detected: feature
jermowery
changed the title
Contributor
Author
|
@andrewseguin as we discussed internally, I have reverted the formatting changes you wanted reverted and added the updated documentation |
Contributor
Author
Contributor
Author
|
@crisbeto the TGP failures appear to be completely contained to the SVG selector you pointed out, any ideas on how we can avoid including the SVG in the progress spinner without making the selector more specific? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new API, testing API, and docs for allowing progress indicators to be projected into a button and have them shown in an accessible manner
Fixes #13667