refactor(aria/multi): Add accessors for pattern properties #32220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolgachev
requested review from
ok7sai and
wagnermaciel
and removed request for
a team
adolgachev
force-pushed
the
aria-props
branch
from
0e85248 to
61d7ae0
Compare
adolgachev
changed the title
adolgachev
force-pushed
the
aria-props
branch
4 times, most recently
from
181fcb8 to
fd799bd
Compare
adolgachev
added
target: rc
adolgachev
force-pushed
the
aria-props
branch
4 times, most recently
from
14aafc4 to
caa13b8
Compare
adolgachev
force-pushed
the
aria-props
branch
from
dbdfad9 to
1591234
Compare
adolgachev
force-pushed
the
aria-props
branch
from
1591234 to
450a94d
Compare
ok7sai
reviewed
Nov 4, 2025
| readonly colWrap = input<'continuous' | 'loop' | 'nowrap'>('loop'); | ||
|
|
||
| /** The currently active cell. */ | ||
| readonly activeCell = computed(() => this._pattern.activeCell()); |
There was a problem hiding this comment.
activeCell is the ui pattern type, so we might want to hide it.
| readonly isFocused = computed(() => this._pattern.isFocused()); | ||
|
|
||
| /** Whether to pause grid navigation. */ | ||
| readonly pauseNavigation = computed(() => this._pattern.pauseNavigation()); |
There was a problem hiding this comment.
This is implementation detail so let's not expose this.
| /** Whether the widget is currently active (focused). */ | ||
| readonly active = computed(() => this._pattern.active()); | ||
| /** Whether the widget is currently the active one (focused). */ | ||
| readonly active = computed(() => this._pattern.active); |
There was a problem hiding this comment.
This seems to return a signal function which I am not sure if it's intended.
| readonly isFocused = computed(() => this._pattern.isFocused()); | ||
|
|
||
| /** Whether the menu has received focus. */ | ||
| readonly hasBeenFocused = computed(() => this._pattern.hasBeenFocused()); |
There was a problem hiding this comment.
This is implementation detail for setting default state that I don't think developers should rely on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.