Repository navigation
fix(cdk-experimental/listbox): clean up the listbox API and make it work with forms - #24920
Merged
Merged
Conversation
Contributor
Author
|
Tests are a mess right now, but wanted to get some feeback on what I have so far. There's a couple questions I had while working on it which are called out in TODOs |
mmalerba
commented
May 13, 2022
crisbeto
reviewed
May 18, 2022
jelbourn
reviewed
May 18, 2022
mmalerba
force-pushed
the
cdk-listbox
branch
2 times, most recently
from
May 20, 2022 00:11
164460a to
81d3d90
Compare
Contributor
Author
|
PTAL, made some changes and left some responses above |
crisbeto
reviewed
May 20, 2022
mmalerba
commented
May 20, 2022
mmalerba
marked this pull request as ready for review
May 20, 2022 22:05
mmalerba
added
the
dev-app preview
|
Deployed dev-app to: https://ng-comp-dev--pr-24920-a51e8ffa965e1319c806e8dc1b1fb8ba-w7fazh0v.web.app |
Contributor
Author
crisbeto
approved these changes
May 25, 2022
crisbeto
approved these changes
May 25, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.