fix(material/form-field): safely coerce line-height to em - #23215
Merged
Conversation
jelbourn
added
P2
google-cla
Bot
added
the
cla: yes
crisbeto
reviewed
Jul 22, 2021
jelbourn
force-pushed
the
form-field-line-height-math
branch
from
July 22, 2021 13:28
62d4085 to
09ae05d
Compare
Our typography mixins for form-field related components coerce line-height to `em` units in several places. If a user provides a `line-height` via typography config with a unit specified, this results in an error as the result with be em squared. This fix changes the coercion to only occur if the line-height is unitless.
jelbourn
force-pushed
the
form-field-line-height-math
branch
from
July 22, 2021 13:31
09ae05d to
7260710
Compare
devversion
approved these changes
Jul 22, 2021
mmalerba
pushed a commit
that referenced
this pull request
Jul 27, 2021
Our typography mixins for form-field related components coerce line-height to `em` units in several places. If a user provides a `line-height` via typography config with a unit specified, this results in an error as the result with be em squared. This fix changes the coercion to only occur if the line-height is unitless. (cherry picked from commit 278e67b)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our typography mixins for form-field related components coerce line-height to
emunits in several places. If a user provides aline-heightvia typography config with a unit specified, this results in an error as the result with be em squared. This fix changes the coercion to only occur if the line-height is unitless.