Skip to content

fix(material-experimental/mdc-table): match legacy examples - #23159

Merged
andrewseguin merged 2 commits into
angular:masterfrom
andrewseguin:mdc-table-example
Jul 15, 2021
Merged

fix(material-experimental/mdc-table): match legacy examples#23159
andrewseguin merged 2 commits into
angular:masterfrom
andrewseguin:mdc-table-example

Conversation

@andrewseguin

Copy link
Copy Markdown
Contributor

Copies the examples over from the legacy table to catch all the edge cases (e.g. expanding rows, wrapped columns, sticky cells)

Needs to be followed up with an update to MDC dependency to catch some recent fixes in their data table styles

@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround merge safe labels Jul 13, 2021
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 13, 2021

@wagnermaciel wagnermaciel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once tests are passing

@andrewseguin andrewseguin added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jul 13, 2021
@andrewseguin andrewseguin changed the title fix(material-experimental/mdc-table): mtach legacy examples fix(material-experimental/mdc-table): match legacy examples Jul 14, 2021
@andrewseguin
andrewseguin merged commit 9c2ea19 into angular:master Jul 15, 2021
andrewseguin added a commit that referenced this pull request Jul 15, 2021
* fix(material-experimental/mdc-table): match legacy examples

* fix(material-experimental/mdc-table): fix mdc css class

(cherry picked from commit 9c2ea19)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants