Skip to content

perf(cdk/scrolling): don't re-measure viewport on resize - #23124

Merged
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:scrolling-clear-cache
Jul 9, 2021
Merged

perf(cdk/scrolling): don't re-measure viewport on resize#23124
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:scrolling-clear-cache

Conversation

@crisbeto

@crisbeto crisbeto commented Jul 6, 2021

Copy link
Copy Markdown
Member

We don't need to re-measure the viewport any time it is resized, we just need to clear the cache so that it is re-measured next time somebody requests it.

We don't need to re-measure the viewport any time it is resized, we just need to clear the cache so that it is re-measured next time somebody requests it.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 6, 2021
@crisbeto
crisbeto requested a review from jelbourn July 6, 2021 21:51
@crisbeto
crisbeto requested a review from andrewseguin as a code owner July 6, 2021 21:51
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2021

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 7, 2021
@wagnermaciel
wagnermaciel merged commit fec20ad into angular:master Jul 9, 2021
wagnermaciel pushed a commit that referenced this pull request Jul 9, 2021
We don't need to re-measure the viewport any time it is resized, we just need to clear the cache so that it is re-measured next time somebody requests it.

(cherry picked from commit fec20ad)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants