Skip to content

fix(material-experimental/mdc-list): support noop animations - #23117

Merged
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:mdc-list-noop-animations
Jul 9, 2021
Merged

fix(material-experimental/mdc-list): support noop animations#23117
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:mdc-list-noop-animations

Conversation

@crisbeto

@crisbeto crisbeto commented Jul 6, 2021

Copy link
Copy Markdown
Member

Fixes that the list animations weren't being disabled with the NoopAnimationsModule.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 6, 2021
@crisbeto
crisbeto requested a review from devversion July 6, 2021 05:47
@crisbeto
crisbeto requested a review from mmalerba as a code owner July 6, 2021 05:47
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2021

@devversion devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor nit

Comment thread src/material-experimental/mdc-list/list-option.scss Outdated
Fixes that the list animations weren't being disabled with the `NoopAnimationsModule`.
@crisbeto
crisbeto force-pushed the mdc-list-noop-animations branch from bfe8184 to e9eceed Compare July 6, 2021 18:30
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 6, 2021
@wagnermaciel
wagnermaciel merged commit e1d775d into angular:master Jul 9, 2021
wagnermaciel pushed a commit that referenced this pull request Jul 9, 2021
Fixes that the list animations weren't being disabled with the `NoopAnimationsModule`.

(cherry picked from commit e1d775d)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants