Skip to content

fix(material-experimental/mdc-tooltip): make background color opaque - #23106

Merged
wagnermaciel merged 3 commits into
angular:masterfrom
wagnermaciel:mdc-tooltip-background-color-opacity
Jul 13, 2021
Merged

fix(material-experimental/mdc-tooltip): make background color opaque#23106
wagnermaciel merged 3 commits into
angular:masterfrom
wagnermaciel:mdc-tooltip-background-color-opacity

Conversation

@wagnermaciel

Copy link
Copy Markdown
Contributor
  • due to a11y concerns surrounding the 0.6 background color opacity of the
    mdc-tooltip, we are switching to using our own custom background color
    instead of the one defined in the MDC styles.

* due to a11y concerns surrounding the 0.6 background color opacity of the
  mdc-tooltip, we are switching to using our own custom background color
  instead of the one defined in the MDC styles.
@wagnermaciel
wagnermaciel requested a review from crisbeto as a code owner July 2, 2021 18:51
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 2, 2021
@wagnermaciel
wagnermaciel requested a review from jelbourn July 2, 2021 18:52
Comment thread src/material-experimental/mdc-tooltip/tooltip.scss Outdated
@wagnermaciel

Copy link
Copy Markdown
Contributor Author

Original mat-tooltip

Screen Shot 2021-07-02 at 9 52 57 AM

Old mat-mdc-tooltip

Screen Shot 2021-07-02 at 9 49 51 AM

New mat-mdc-tooltip

Screen Shot 2021-07-02 at 11 42 50 AM

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release P2 The issue is important to a large percentage of users, with a workaround labels Jul 2, 2021
Comment thread src/material-experimental/mdc-tooltip/_tooltip-theme.scss Outdated
@wagnermaciel
wagnermaciel merged commit e134598 into angular:master Jul 13, 2021
wagnermaciel added a commit that referenced this pull request Jul 13, 2021
…23106)

* fix(material-experimental/mdc-tooltip): make background color opaque

* due to a11y concerns surrounding the 0.6 background color opacity of the
  mdc-tooltip, we are switching to using our own custom background color
  instead of the one defined in the MDC styles.

* fixup! fix(material-experimental/mdc-tooltip): make background color opaque

* fixup! fix(material-experimental/mdc-tooltip): make background color opaque

(cherry picked from commit e134598)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 13, 2021
@wagnermaciel
wagnermaciel deleted the mdc-tooltip-background-color-opacity branch November 20, 2025 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants