Skip to content

Calling mdc-fab.extended_ with $mat-base-styles query by default. - #23103

Merged
andrewseguin merged 1 commit into
angular:masterfrom
alexemorris:patch-1
Jul 2, 2021
Merged

Calling mdc-fab.extended_ with $mat-base-styles query by default.#23103
andrewseguin merged 1 commit into
angular:masterfrom
alexemorris:patch-1

Conversation

@alexemorris

Copy link
Copy Markdown

mdc-fab.extended_ was being called without a query meaning it brought in lots of additional overrides including typography making typography mixins for mdc-fabs ineffective.

mdc-fab.extended_ was being called without a query meaning it brought in lots of additional overrides including typography making typography mixins for fabs ineffective.
@alexemorris
alexemorris requested a review from andrewseguin as a code owner July 1, 2021 15:17
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 1, 2021
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Jul 1, 2021
@andrewseguin andrewseguin added G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround labels Jul 1, 2021
@andrewseguin
andrewseguin merged commit 36fbae1 into angular:master Jul 2, 2021
andrewseguin pushed a commit that referenced this pull request Jul 2, 2021
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants