fix(material/core): align ripple animation parameters with spec - #23086
Merged
Merged
Conversation
crisbeto
added
P3
google-cla
Bot
added
the
cla: yes
crisbeto
commented
Jun 29, 2021
devversion
approved these changes
Jun 29, 2021
devversion
left a comment
devversion
left a comment
Member
There was a problem hiding this comment.
LGTM, either way works for me with the start scale.
Contributor
|
Repeating here our discussion from Slack (because I can't upload webm videos on GitHub) for transparency: It looks like this value isn't applied directly to |
Aligns the ripple timings with the numbers from MDC.
crisbeto
force-pushed
the
ripple-parameters
branch
from
July 3, 2021 11:08
7352c89 to
5342e06
Compare
Member
Author
|
I've reverted the change to the initial scale. |
devversion
approved these changes
Jul 3, 2021
wagnermaciel
pushed a commit
that referenced
this pull request
Jul 9, 2021
Aligns the ripple timings with the numbers from MDC. (cherry picked from commit 0816f08)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the ripple timings with the numbers from MDC.