fix(material-experimental/mdc-slider): event handling fixes and cleanup - #23063
Merged
Conversation
* Fixes that the `mouseenter` and `mouseleave` handlers on the slider were leaking. It was `Function.bind` returns a new function and we weren't passing the same function in when the component is destroyed. * Fixes that slider was calling `unsubscribe` on subjects that belong to the slider thumbs. `Subject.unsubscribe` will drop all subscriptions to the observable, including ones that come from the outside. The correct thing to do is to either complete the observables or save a reference to the `Subscription` and call `unsubscribe` on it. * Removes the `*Ctor` interfaces from the mixin class since it isn't necessary anymore.
crisbeto
added
P3
google-cla
Bot
added
the
cla: yes
devversion
approved these changes
Jun 26, 2021
amysorto
pushed a commit
that referenced
this pull request
Jun 28, 2021
…up (#23063) * Fixes that the `mouseenter` and `mouseleave` handlers on the slider were leaking. It was `Function.bind` returns a new function and we weren't passing the same function in when the component is destroyed. * Fixes that slider was calling `unsubscribe` on subjects that belong to the slider thumbs. `Subject.unsubscribe` will drop all subscriptions to the observable, including ones that come from the outside. The correct thing to do is to either complete the observables or save a reference to the `Subscription` and call `unsubscribe` on it. * Removes the `*Ctor` interfaces from the mixin class since it isn't necessary anymore. (cherry picked from commit 91fa44e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mouseenterandmouseleavehandlers on the slider were leaking. It wasFunction.bindreturns a new function and we weren't passing the same function in when the component is destroyed.unsubscribeon subjects that belong to the slider thumbs.Subject.unsubscribewill drop all subscriptions to the observable, including ones that come from the outside. The correct thing to do is to either complete the observables or save a reference to theSubscriptionand callunsubscribeon it.*Ctorinterfaces from the mixin class since it isn't necessary anymore.