fix(cdk/stepper): focus management not working with shadow dom encapsulation - #23047
Merged
Merged
Conversation
crisbeto
added
P3
google-cla
Bot
added
the
cla: yes
crisbeto
force-pushed
the
stepper-shadow-dom-focus
branch
from
June 23, 2021 15:11
48939ad to
c0a224b
Compare
devversion
approved these changes
Jun 23, 2021
crisbeto
force-pushed
the
stepper-shadow-dom-focus
branch
from
June 23, 2021 16:28
c0a224b to
256f93b
Compare
crisbeto
force-pushed
the
stepper-shadow-dom-focus
branch
2 times, most recently
from
June 24, 2021 15:33
5418385 to
d0da439
Compare
…ulation The CDK stepper focus management checks against the document to find the focused element which won't work if the stepper is inside the shadow DOM. These changes use our shadow DOM helper to resolve the element instead.
crisbeto
force-pushed
the
stepper-shadow-dom-focus
branch
from
June 24, 2021 19:53
d0da439 to
9ce4130
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CDK stepper focus management checks against the document to find the focused element which won't work if the stepper is inside the shadow DOM. These changes use our shadow DOM helper to resolve the element instead.