fix(cdk/overlay): use interface for test environment globals - #23041
Merged
Conversation
jelbourn
added
P2
google-cla
Bot
added
the
cla: yes
The previous approach of using `declare const` was causing collisions with the real test environment types inside Google.
amysorto
pushed a commit
that referenced
this pull request
Jun 28, 2021
The previous approach of using `declare const` was causing collisions with the real test environment types inside Google. (cherry picked from commit da91c18)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous approach of using
declare constwas causing collisions with the real test environment types inside Google.