Skip to content

fix(cdk/a11y): fake mousedown detection not working - #23029

Merged
andrewseguin merged 1 commit into
angular:masterfrom
crisbeto:22549/fake-mousedown-detection
Jul 2, 2021
Merged

fix(cdk/a11y): fake mousedown detection not working#23029
andrewseguin merged 1 commit into
angular:masterfrom
crisbeto:22549/fake-mousedown-detection

Conversation

@crisbeto

@crisbeto crisbeto commented Jun 21, 2021

Copy link
Copy Markdown
Member

Our approach to detecting fake mousedown events from screen readers doesn't appear to work with a recent version of NVDA. These changes switch to using offsetX and offsetY instead.

Fixes #22549.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Jun 21, 2021
@crisbeto
crisbeto requested a review from jelbourn June 21, 2021 15:12
@crisbeto
crisbeto requested a review from devversion as a code owner June 21, 2021 15:12
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 21, 2021
@crisbeto
fix(cdk/a11y): fake mousedown detection not working
7cf352a 
Our approach to detecting fake `mousedown` events from screen readers doesn't appear to work with a recent version of NVDA. These changes switch to using `offsetX` and `offsetY` instead.

Fixes angular#22549.
@crisbeto
crisbeto force-pushed the 22549/fake-mousedown-detection branch from d6a0a2d to 7cf352a Compare June 21, 2021 15:26
@crisbeto
crisbeto requested a review from mmalerba as a code owner June 21, 2021 15:26
jelbourn
jelbourn approved these changes Jun 21, 2021
View reviewed changes

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jun 21, 2021
@andrewseguin
andrewseguin merged commit a18d26f into angular:master Jul 2, 2021
andrewseguin pushed a commit that referenced this pull request Jul 2, 2021
@crisbeto @andrewseguin
fix(cdk/a11y): fake mousedown detection not working (#23029)
4de15ea 
Our approach to detecting fake `mousedown` events from screen readers doesn't appear to work with a recent version of NVDA. These changes switch to using `offsetX` and `offsetY` instead.

Fixes #22549.

(cherry picked from commit a18d26f)
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Aug 2, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion Awaiting requested review from devversion
@mmalerba mmalerba Awaiting requested review from mmalerba
1 more reviewer
@jelbourn jelbourn jelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(cdk/a11y): [Safari] [Chrome] [MacOS] FocusMonitor improperly identifies subsequent right mouse clicks as keyboard focus origin

3 participants

@crisbeto @jelbourn @andrewseguin