fix(material/core): Focus indicator theme and color mixins should accept a basic color as well. - #23016
Merged
Merged
Conversation
google-cla
Bot
added
the
cla: yes
zelliott
force-pushed
the
focus-indicator-color
branch
from
June 18, 2021 17:59
185446d to
8078cb9
Compare
…ept a basic color as well. fix(core/material): Disable styelint for focus indicator theme mixins.
zelliott
force-pushed
the
focus-indicator-color
branch
from
June 18, 2021 18:23
8078cb9 to
ea090ab
Compare
zelliott
marked this pull request as ready for review
June 18, 2021 18:33
jelbourn
added
G
mmalerba
added
target: minor
Contributor
|
I think this should be considered a patch. Colors as an input was supported in 12.0, and is not supported in 12.1.x. I think this is an unintentional breaking change. |
Contributor
|
@mmalerba was this changed to minor due to merge conflicts? |
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jul 8, 2021
…ept a basic color as well. (angular#23016) fix(core/material): Disable styelint for focus indicator theme mixins.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in https://material.angular.io/guide/theming#customizing-strong-focus-indicators, the focus indicator theme and color mixins should allow the user to pass in a basic CSS color. This PR updates the mixins to allow this.
Alternatively, we could update the documentation to disallow this. I disabled the stylelint checks for these mixins because their new implementations aren't compatible with the checks.