fix(material/menu): submenu icon not working in high contrast mode - #23012
Merged
Conversation
crisbeto
added
P2
google-cla
Bot
added
the
cla: yes
Currently the submenu icon is rendered as a CSS triangle which turns into a rectangle in high contrast mode. These changes resolve the issue by using SVG for the icon instead. Fixes angular#22944.
crisbeto
force-pushed
the
22944/menu-submenu-icon-a11y
branch
from
June 18, 2021 15:07
ab2f67a to
8f185b1
Compare
jelbourn
added
the
merge: caretaker note
Contributor
|
Caretaker note: this is going to be screenshot city |
Member
Author
|
For what it's worth, I was verifying that the new icon size and position was the same as the old one by laying one on top of the other. |
mmalerba
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the submenu icon is rendered as a CSS triangle which turns into a rectangle in high contrast mode. These changes resolve the issue by using SVG for the icon instead.
Fixes #22944.