fix(material/badge): avoid emitting the structural styles more than once - #23011
Merged
Merged
Conversation
The badge structural styles are currently in the theme, because the badge is a directive and Angular doesn't support associating styles with directives. The problem is that it'll cause the same structural styles to be emitted multiple times unnecessarily. These changes add some logic that will try to prevent the structural styles from being emitted more than once. **Disclaimer:** this change might not work across multiple compilation units, however I still think it's worthwhile, because the apps that only have one global stylesheet for their theme will get the benefit, while everybody else will work the same as before. These changes shave off more than 4kb of minified CSS.
crisbeto
added
P3
google-cla
Bot
added
the
cla: yes
jelbourn
reviewed
Jun 18, 2021
jelbourn
left a comment
jelbourn
left a comment
Contributor
There was a problem hiding this comment.
Does this still work with the Sass module system? My understanding was that variables are re-initialized every time they're imported via the module system, so this trick of keeping state as the compilation advances doesn't work any more.
Member
Author
|
I added the Even if it does get reset, it'll keep working like it does today, but at least some users will get the benefit of less generated CSS. |
mmalerba
pushed a commit
that referenced
this pull request
Jun 22, 2021
…nce (#23011) The badge structural styles are currently in the theme, because the badge is a directive and Angular doesn't support associating styles with directives. The problem is that it'll cause the same structural styles to be emitted multiple times unnecessarily. These changes add some logic that will try to prevent the structural styles from being emitted more than once. **Disclaimer:** this change might not work across multiple compilation units, however I still think it's worthwhile, because the apps that only have one global stylesheet for their theme will get the benefit, while everybody else will work the same as before. These changes shave off more than 4kb of minified CSS. (cherry picked from commit b7db96c)
mmalerba
pushed a commit
that referenced
this pull request
Jun 22, 2021
…nce (#23011) The badge structural styles are currently in the theme, because the badge is a directive and Angular doesn't support associating styles with directives. The problem is that it'll cause the same structural styles to be emitted multiple times unnecessarily. These changes add some logic that will try to prevent the structural styles from being emitted more than once. **Disclaimer:** this change might not work across multiple compilation units, however I still think it's worthwhile, because the apps that only have one global stylesheet for their theme will get the benefit, while everybody else will work the same as before. These changes shave off more than 4kb of minified CSS. (cherry picked from commit b7db96c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The badge structural styles are currently in the theme, because the badge is a directive and Angular doesn't support associating styles with directives. The problem is that it'll cause the same structural styles to be emitted multiple times unnecessarily.
These changes add some logic that will try to prevent the structural styles from being emitted more than once.
Disclaimer: this change might not work across multiple compilation units, however I still think it's worthwhile, because the apps that only have one global stylesheet for their theme will get the benefit, while everybody else will work the same as before. These changes shave off more than 4kb of minified CSS.