fix(material-experimental/mdc-snack-bar): increase the specificity of styles targeting the action buttons - #22959
Merged
Merged
Conversation
styles targeting the action buttons. Currently the order of the button theme vs the snackbar theme matters, this will make the snackbar theme always take precedence
mmalerba
added
P2
google-cla
Bot
added
the
cla: yes
crisbeto
reviewed
Jun 11, 2021
Contributor
|
lol four classes - I feel for the dev who tries to override that style in their app |
andrewseguin
approved these changes
Jun 11, 2021
… styles targeting the action buttons.
mmalerba
force-pushed
the
snackbar-specificity
branch
from
June 11, 2021 15:52
bf2cd37 to
efe8666
Compare
mmalerba
added a commit
that referenced
this pull request
Jun 18, 2021
… styles targeting the action buttons (#22959) * fix(material-experimental/mdc-snack-bar): increase the specificity of styles targeting the action buttons. Currently the order of the button theme vs the snackbar theme matters, this will make the snackbar theme always take precedence * fix(material-experimental/mdc-snack-bar): increase the specificity of styles targeting the action buttons. (cherry picked from commit 2c57c58)
mmalerba
added a commit
that referenced
this pull request
Jun 18, 2021
… styles targeting the action buttons (#22959) * fix(material-experimental/mdc-snack-bar): increase the specificity of styles targeting the action buttons. Currently the order of the button theme vs the snackbar theme matters, this will make the snackbar theme always take precedence * fix(material-experimental/mdc-snack-bar): increase the specificity of styles targeting the action buttons. (cherry picked from commit 2c57c58)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the order of the button theme vs the snackbar theme matters,
this will make the snackbar theme always take precedence