Repository navigation
build(table): explicitly define MatTable ctor - #10982
Conversation
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Is this necessary for 6.0?
| }) | ||
| export class MatTable<T> extends CdkTable<T> { } | ||
| export class MatTable<T> extends CdkTable<T> { | ||
| // TODO(andrewseguin): Remove this explicitly set ctor when the compiler knows how to properly |
There was a problem hiding this comment.
Prefer constructor to ctor
|
It's not necessary for 6.0 but would be nice to have in sooner than later. However as of right now we are distributing a broken build of table.js for all ES6 users. https://unpkg.com/@angular/material@5.2.5/esm2015/table.js |
|
Marking as P1, then. |
|
Can we expect this to be in RC.15? We really need to use Material Tables targeting ES6. |
|
@VangelisAlSghir Yes, it should be fixed as of |
|
Are you sure? I just made a new angular project and targeted ES6 and tried to use a material table with the example code from https://github.com/angular/material2/blob/6.0.0-rc.14/src/demo-app/table/mat-table-data-source/mat-table-data-source.html but I still get following errors in the console: TypeError: Cannot read property 'find' of undefined and ypeError: Cannot read property 'diff' of undefined |
|
Ah bummer, looks like the same "fix" needs to be applied to those classes as well. Will be able to make a change next week but it'll like be a part of v6.0.1 or v6.0.2 |
|
The sooner the better for us :) |
|
PR has been created, hoping it'll be merged this week and go out with our next release on Monday. Thanks for your patience and persistence with the issue |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Explicitly define the ctor due to a tsickle issue which is depended on by compiler-cli.
Fixes #9329