Skip to content

added env FIREBASE_TOKEN to deploy at CI/CD#2525

Closed
yasinkocak wants to merge 4 commits intoangular:masterfrom
yasinkocak:master
Closed

added env FIREBASE_TOKEN to deploy at CI/CD#2525
yasinkocak wants to merge 4 commits intoangular:masterfrom
yasinkocak:master

Conversation

@yasinkocak
Copy link
Copy Markdown
Contributor

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Allow to use env FIREBASE_TOKEN while deploying on CI/CD

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@yasinkocak
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@yasinkocak
Copy link
Copy Markdown
Contributor Author

yasinkocak commented Jun 26, 2020

issue #2523 #2482 #2327

@alessio-libardi
Copy link
Copy Markdown

Please someone review this PR.

@ammaarpatel99
Copy link
Copy Markdown

Just wondering if there is any progress on this

@YogliB
Copy link
Copy Markdown

YogliB commented Sep 30, 2020

anyone reviewing this?

@jamesdaniels
Copy link
Copy Markdown
Member

Sorry for this being slow, API additions have to wait until the next minor release is planned. 6.1 is dropping shortly. There's already a PR here #2327 that I'm aiming to pull in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants