chore(): removing the new peers, unneeded and confusing to existing users#2095
Merged
Conversation
Contributor
Author
|
This is minor enough and the tests are green, cutting as |
jhuleatt
approved these changes
Jul 3, 2019
jhuleatt
left a comment
jhuleatt
left a comment
Collaborator
There was a problem hiding this comment.
Sorry I missed this, LGTM
Contributor
Author
|
@jhuleatt no worries, I had already cut since it was straight forward enough and passed smoke tests. Thanks for the green light for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
The new peerDependencies included for the schematics aren't necessary to include in the published package and the peer warnings are confusing, especially for yarn users.
The dependencies on
fuzzy,inquirer, and the@angular-devkit/*are taken care of if the developer usesng add @angular/fire(4ed421c) and are only used in that step.The
firebase-toolsdependency doesn't have to be expressed as a peer, as if you try to dong deploywithoutfirebase-toolsinstalled you get a good error: