This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
docs(guide/module) fixed disabled global cntl - #8248
Closed
vandycknick wants to merge 1 commit into
Closed
vandycknick wants to merge 1 commit into
vandycknick wants to merge 1 commit into
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Contributor
|
Hi, thanks for the PR. However, I think it makes more sense to use the common way of registering a controller: Can you update the PR? |
Example contained a global controller. **How to reproduce:** https://docs.angularjs.org/guide/module **Plunker with fix:** http://plnkr.co/jwu6ZBTNzOZjVqy1lLEo
Contributor
Author
|
Updated PR, I actually kept in the original run block. Although i think it doesn't add much more clarity if i look back at what this part of the docs is explaining |
Contributor
|
LGTM. Merging |
petebacondarwin
pushed a commit
that referenced
this pull request
Jul 18, 2014
Global controllers have been disallowed in Angular 1.3 Closes #8248
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example contained a global controller.
How to reproduce: https://docs.angularjs.org/guide/module
Plunker with fix: http://plnkr.co/jwu6ZBTNzOZjVqy1lLEo